Skip to content

Conversation

@chaitanyalal18
Copy link
Contributor

PR Description:

An after insert Business rule logic to move attachment from attachment variable to the RITM

Pull Request Checklist

Overview

  • Put an x inside of the square brackets to check each item.
  • I have read and understood the CONTRIBUTING.md guidelines
  • My pull request has a descriptive title that accurately reflects the changes and the description has been filled in above.
  • I've included only files relevant to the changes described in the PR title and description
  • I've created a new branch in my forked repository for this contribution

Code Quality

  • My code is relevant to ServiceNow developers
  • My code snippets expand meaningfully on official ServiceNow documentation (if applicable)
  • I've disclosed use of ES2021 features (if applicable)
  • I've tested my code snippets in a ServiceNow environment (where possible)

Repository Structure Compliance

  • I've placed my code snippet(s) in one of the required top-level categories:
    • Core ServiceNow APIs/
    • Server-Side Components/
    • Client-Side Components/
    • Modern Development/
    • Integration/
    • Specialized Areas/
  • I've used appropriate sub-categories within the top-level categories
  • Each code snippet has its own folder with a descriptive name

Documentation

  • I've included a README.md file for each code snippet
  • The README.md includes:
    • Description of the code snippet functionality
    • Usage instructions or examples
    • Any prerequisites or dependencies
    • (Optional) Screenshots or diagrams if helpful

Restrictions

  • My PR does not include XML exports of ServiceNow records
  • My PR does not contain sensitive information (passwords, API keys, tokens)
  • My PR does not include changes that fall outside the described scope

@rohi-v rohi-v self-assigned this Oct 23, 2025
@rohi-v
Copy link
Contributor

rohi-v commented Oct 23, 2025

HI @chaitanyalal18

Instead of querying attachment table which can be very large, we can simply update the attachment record with the sys_id we have from the variable value.

Let me know your thoughts.

@chaitanyalal18
Copy link
Contributor Author

chaitanyalal18 commented Oct 24, 2025

Hi @rohi-v
Thanks for pointing that out. I was considering it from the angle that if an RITM has multiple attachment variables, the same operation could be performed on the filtered attachment records without needing to specify each attachment variable’s sys_id individually. I think I can incorporate the changes you mentioned to handle multiple attachment variables as well. I will update the script and README accordingly.

@chaitanyalal18
Copy link
Contributor Author

@rohi-v I have made changes to the files. Please have a look now. Thanks!

@rohi-v
Copy link
Contributor

rohi-v commented Oct 24, 2025

Looks Good

ThankYou for contribution

@chaitanyalal18
Copy link
Contributor Author

@rohi-v Thank you! PR seems to be open. Can you merge and close it

@rohi-v rohi-v merged commit 61ecc85 into ServiceNowDevProgram:main Oct 24, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants